Repository navigation
Outline the wordmark's middle slash, as the web does - #29
Merged
Merged
Conversation
simonhamp
marked this pull request as draft
October 20, 2026 16:10
The /dev/null wordmark's middle slash is now a hollow lane-0 outline, like the web's, using text-outline from NativePHP/mobile-air#549 and NativePHP/mobile-ui#142. It replaces the solid regular-weight slash #20 used because EDGE text couldn't stroke a glyph then. Main's lock already has a mobile-air combined head with #549. This moves nativephp/mobile-ui to the combined/dev-null-app head that has #142. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
simonhamp
force-pushed
the
feat/outlined-wordmark-slash
branch
from
October 20, 2026 22:29
e2ebcda to
b7b4fb6
Compare
composer.lock conflicted because main moved onto mobile-air and mobile-ui dev-main in #75. Main's lock predates the text-outline merges (mobile-air#549, mobile-ui#142), so this takes main's lock and moves only nativephp/mobile to 2189e72 and nativephp/mobile-ui to 0abe5d2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wordmark's middle slash is now a hollow lane-0 outline, like the web's. #20 had to use a solid regular-weight slash because EDGE text couldn't stroke a glyph. NativePHP/mobile-air#549 and NativePHP/mobile-ui#142 add
text-outline, and both are merged to main.What changed
class="text-outline text-theme-lane-0", so it keeps the wordmark's semibold glyph and draws its outline 1pt wide. That's what the web'smax(1px, 0.035em)comes to at body sizes.composer.lockmovesnativephp/mobilefrom 557de01 to 2189e72 andnativephp/mobile-uifrom b2a8b2a to 0abe5d2 (the #142 squash). Those are the current dev-main heads, so they also bring in the other commits that landed since: 27 in mobile-air and 14 in mobile-ui. Nothing else in the lock changed.text_outline1.0 instead of the regular weight.Screenshots
From mobile-ui#142. The web is on top, #20's solid slash in the middle, and this PR at the bottom, all at 17pt on iOS:
Those came from a test build with both changes patched into
vendor. I also built an earlier version of this branch on an iPhone 17 Pro simulator (iOS 27) and the slash drew the same. I haven't built it on the new lock yet.Worth checking
SwiftUINodeRenderer. That isn't from this change, and Debug builds work.Testing
Merged main in to fix the
composer.lockconflict from #75. 1196 tests pass and Pint is clean.🤖 Generated with Claude Code